VAN-4147 Remove use of ACL to set AWS bucket private#103
Merged
dshelley66 merged 1 commit intomainfrom Jun 8, 2023
Merged
Conversation
AWS now defaults buckets to be private and disables ACL use so we no longer need to set this.
Contributor
Author
|
/azp run codepipes-tutorials-test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run codepipes-tutorials-test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@dshelley66 We made this PR for the ACL issue. Please check if that make sense? |
Contributor
Author
@rajatsharma111 this fixes the cust-acct-setup script - I don't think that was covered in your PR |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
petmal
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS now defaults buckets to be private and disables ACL use so we
no longer need to set this.